feat(octavia): add pool edition view #10435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacquesLarique
requested review from
dectotam,
darsene and
sachinrameshn
and removed request for
a team
github-actions
bot
added
translation required
feature
JacquesLarique
force-pushed
the
feat/MANAGER-12302
branch
from
37c1c64 to
58dc8fa
Compare
github-actions
bot
removed
the
has conflicts
darsene
reviewed
Dec 1, 2023
...tavia-load-balancer/src/load-balancers/load-balancer/pools/components/pool-form/constants.js
Outdated
Show resolved
Hide resolved
...avia-load-balancer/src/load-balancers/load-balancer/pools/components/pool-form/controller.js
Outdated
Show resolved
Hide resolved
darsene
reviewed
Dec 1, 2023
Comment on lines
5
to
21
| const persistenceTypes = ['sourceIP', 'httpCookie', 'appCookie']; | ||
|
|
||
| export const APP_COOKIE_SESSION_PERSISTENCE = persistenceTypes[2]; | ||
|
|
||
| export const PROTOCOL_SESSION_PERSISTENCE_TYPE_COMBINATION = { | ||
| http: persistenceTypes, | ||
| https: persistenceTypes, | ||
| tcp: persistenceTypes, | ||
| proxy: persistenceTypes, | ||
| proxyV2: persistenceTypes, | ||
| udp: [persistenceTypes[0]], | ||
| sctp: [persistenceTypes[0]], | ||
| }; |
There was a problem hiding this comment.
Sorry, I didn't pay attention that some properties was already existing
Suggested change
| const persistenceTypes = ['sourceIP', 'httpCookie', 'appCookie']; | |
| export const APP_COOKIE_SESSION_PERSISTENCE = persistenceTypes[2]; | |
| export const PROTOCOL_SESSION_PERSISTENCE_TYPE_COMBINATION = { | |
| http: persistenceTypes, | |
| https: persistenceTypes, | |
| tcp: persistenceTypes, | |
| proxy: persistenceTypes, | |
| proxyV2: persistenceTypes, | |
| udp: [persistenceTypes[0]], | |
| sctp: [persistenceTypes[0]], | |
| }; | |
| export const DEFAULT_SESSION_PERSISTENCE_TYPE = 'sourceIP'; | |
| eexport const APP_COOKIE_SESSION_PERSISTENCE = 'appCookie'; | |
| const persistenceTypes = [ | |
| DEFAULT_SESSION_PERSISTENCE_TYPE, | |
| 'httpCookie', | |
| APP_COOKIE_SESSION_PERSISTENCE | |
| ]; | |
| export const PROTOCOL_SESSION_PERSISTENCE_TYPE_COMBINATION = { | |
| http: persistenceTypes, | |
| https: persistenceTypes, | |
| tcp: persistenceTypes, | |
| proxy: persistenceTypes, | |
| proxyV2: persistenceTypes, | |
| udp: [DEFAULT_SESSION_PERSISTENCE_TYPE], | |
| sctp: [DEFAULT_SESSION_PERSISTENCE_TYPE], | |
| }; |
github-actions
bot
added
the
has conflicts
added 6 commits
December 1, 2023 17:57
ref: MANAGER-12302 Signed-off-by: Jacques Larique <[email protected]>
Signed-off-by: CDS Translator Agent <[email protected]>
ref: MANAGER-12302 Signed-off-by: Jacques Larique <[email protected]>
ref: MANAGER-12302 Signed-off-by: Jacques Larique <[email protected]>
ref: MANAGER-12302 Signed-off-by: Jacques Larique <[email protected]>
ref: MANAGER-12302 Signed-off-by: Jacques Larique <[email protected]>
JacquesLarique
force-pushed
the
feat/MANAGER-12302
branch
from
1777bcb to
3a1a171
Compare
github-actions
bot
removed
the
has conflicts
darsene
approved these changes
Dec 1, 2023
|
SonarCloud Quality Gate failed.
|
BrunoMarquesOVH
approved these changes
Dec 1, 2023
JacquesLarique
added a commit
that referenced
this pull request
Jan 9, 2024
ref: MANAGER-12302 Signed-off-by: Jacques Larique <[email protected]> Co-authored-by: CDS Translator Agent <[email protected]>
JacquesLarique
added a commit
that referenced
this pull request
Feb 5, 2024
ref: MANAGER-12302 Signed-off-by: Jacques Larique <[email protected]> Co-authored-by: CDS Translator Agent <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat/octavia-batch-1Breaking change is mentioned in relevant commits(n/a)Description
Added pool edition page
Related