-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests for mr secure db section #3623
Tests for mr secure db section #3623
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3623 +/- ##
==========================================
- Coverage 85.29% 85.18% -0.12%
==========================================
Files 1395 1404 +9
Lines 32047 32243 +196
Branches 8983 9042 +59
==========================================
+ Hits 27336 27465 +129
- Misses 4711 4778 +67
... and 58 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @manaswinidas !
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mturley The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Tests for RHOAIENG-15899
Description
Added unit test for
useModelRegistryCertificateNames
hook and Cypress tests for MR secure DB sectionHow Has This Been Tested?
Run the unit test file and Cypress tests using the commands from README
Test Impact
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main