Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for mr secure db section #3623

Merged

Conversation

manaswinidas
Copy link
Contributor

@manaswinidas manaswinidas commented Jan 8, 2025

Tests for RHOAIENG-15899

Description

Added unit test for useModelRegistryCertificateNames hook and Cypress tests for MR secure DB section

How Has This Been Tested?

Run the unit test file and Cypress tests using the commands from README

Test Impact

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@manaswinidas manaswinidas changed the title Tests mr secure db Tests for mr secure db section Jan 8, 2025
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.18%. Comparing base (ce63518) to head (8918fa6).
Report is 21 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3623      +/-   ##
==========================================
- Coverage   85.29%   85.18%   -0.12%     
==========================================
  Files        1395     1404       +9     
  Lines       32047    32243     +196     
  Branches     8983     9042      +59     
==========================================
+ Hits        27336    27465     +129     
- Misses       4711     4778      +67     
Files with missing lines Coverage Δ
.../modelRegistrySettings/CreateMRSecureDBSection.tsx 64.89% <ø> (+52.12%) ⬆️
...nd/src/pages/modelRegistrySettings/CreateModal.tsx 87.38% <ø> (+6.30%) ⬆️

... and 58 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce63518...8918fa6. Read the comment docs.

@ppadti
Copy link
Contributor

ppadti commented Jan 9, 2025

/lgtm

Copy link
Contributor

@mturley mturley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @manaswinidas !

Copy link
Contributor

openshift-ci bot commented Jan 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mturley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jan 9, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 72c185b into opendatahub-io:main Jan 9, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants