-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cypress tests to MR secure DB section #3631
Add cypress tests to MR secure DB section #3631
Conversation
0ab949a
to
b663ff1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3631 +/- ##
==========================================
+ Coverage 85.14% 85.40% +0.26%
==========================================
Files 1406 1406
Lines 32298 32313 +15
Branches 9060 9067 +7
==========================================
+ Hits 27499 27596 +97
+ Misses 4799 4717 -82
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
The tests for scenarios discussed are covered
@@ -51,3 +51,20 @@ export const constructRequestBody = ( | |||
|
|||
return mr; | |||
}; | |||
|
|||
export const isClusterWideCABundleEnabled = ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may require unit tests but codecov
didn't catch this.. so we can maybe ignore the unit tests.. the cypress tests cover this scenario.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks guys!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mturley The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
followup PR to #3623 and #3618
Description
This PR aims to add cypress test for MR secureDB section and address few bugs mentioned here
How Has This Been Tested?
Test Impact
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main