Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameterise ColumnIndexer #2949

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Conversation

mrmr1993
Copy link
Member

This PR builds upon #2948, adding a type parameter to ColumnIndexer corresponding to the parameter for Column. This retains the usize type everywhere for now.

Base automatically changed from feature/add-parameter-to-column to master January 13, 2025 18:20
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 86.36364% with 3 lines in your changes missing coverage. Please review.

Project coverage is 76.61%. Comparing base (21c8196) to head (f3b8e20).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
msm/src/ffa/mod.rs 0.00% 2 Missing ⚠️
msm/src/circuit_design/capabilities.rs 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2949      +/-   ##
==========================================
- Coverage   76.61%   76.61%   -0.01%     
==========================================
  Files         255      255              
  Lines       60855    60867      +12     
==========================================
+ Hits        46626    46633       +7     
- Misses      14229    14234       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrmr1993 mrmr1993 merged commit efa29bb into master Jan 13, 2025
12 checks passed
@mrmr1993 mrmr1993 deleted the feature/add-parameter-to-column-indexer branch January 13, 2025 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants