Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track lookup values in interpreter and proof #2946

Closed
wants to merge 18 commits into from

Conversation

mrmr1993
Copy link
Member

This PR builds upon #2943. This propagates the values involved with lookups as witness columns for the prover.

The majority of changes in this PR are caused by unwinding the old misguided manual mapping of columns to indices. That model still exists in some old, dead code, but we use the now-generic witness kind to remove it where it matters for this PR.

Copy link

codecov bot commented Jan 12, 2025

Codecov Report

Attention: Patch coverage is 76.06383% with 45 lines in your changes missing coverage. Please review.

Project coverage is 76.60%. Comparing base (3796eb9) to head (487e282).

Files with missing lines Patch % Lines
o1vm/src/pickles/main.rs 0.00% 18 Missing ⚠️
o1vm/src/pickles/prover.rs 82.75% 5 Missing ⚠️
o1vm/src/pickles/verifier.rs 54.54% 5 Missing ⚠️
ivc/src/expr_eval.rs 0.00% 4 Missing ⚠️
o1vm/src/pickles/column_env.rs 86.36% 3 Missing ⚠️
msm/src/ffa/mod.rs 0.00% 2 Missing ⚠️
ivc/src/plonkish_lang.rs 0.00% 1 Missing ⚠️
ivc/src/prover.rs 0.00% 1 Missing ⚠️
ivc/src/verifier.rs 0.00% 1 Missing ⚠️
msm/src/circuit_design/capabilities.rs 75.00% 1 Missing ⚠️
... and 4 more
Additional details and impacted files
@@                    Coverage Diff                     @@
##           feature/logup-tracking    #2946      +/-   ##
==========================================================
- Coverage                   76.60%   76.60%   -0.01%     
==========================================================
  Files                         255      255              
  Lines                       60897    61014     +117     
==========================================================
+ Hits                        46650    46738      +88     
- Misses                      14247    14276      +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrmr1993 mrmr1993 marked this pull request as draft January 13, 2025 17:15
@mrmr1993
Copy link
Member Author

Converted to draft. This requires some more cleanup and fixes before it's ready for review. The refactoring changes have been split out into #2948, #2949, and #2950, which are ready for review.

@mrmr1993
Copy link
Member Author

Closing in favour of #2951

@mrmr1993 mrmr1993 closed this Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant