Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multiplicity tracking for lookups #2943

Open
wants to merge 12 commits into
base: feature/reasonable-relation-type
Choose a base branch
from

Conversation

mrmr1993
Copy link
Member

@mrmr1993 mrmr1993 commented Jan 10, 2025

This PR builds upon #2950. This PR adds tracking for fixed-table multiplicities in the witness generation. We can use these to inject them at the end of execution, for use in the lookup protocol. This way, we can use the delayed lookup argument for everything.

The indexing code is bad; this is mostly derived from existing code.

Copy link

codecov bot commented Jan 12, 2025

Codecov Report

Attention: Patch coverage is 65.95745% with 16 lines in your changes missing coverage. Please review.

Project coverage is 76.60%. Comparing base (2136d6c) to head (3796eb9).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
o1vm/src/interpreters/mips/witness.rs 64.51% 11 Missing ⚠️
o1vm/src/lookups.rs 66.66% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2943      +/-   ##
==========================================
- Coverage   76.61%   76.60%   -0.01%     
==========================================
  Files         255      255              
  Lines       60855    60897      +42     
==========================================
+ Hits        46622    46650      +28     
- Misses      14233    14247      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrmr1993 mrmr1993 changed the base branch from master to feature/reasonable-relation-type January 13, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant