-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export TreeSummarizedExperiment R object #807
base: dev
Are you sure you want to change the base?
Conversation
Cool! In SummarizedExperiment:
This error occurs if those names do not match, they must be exactly the same (same order also). I can check this week. If the names do not match because of different order, it is simple to sort the data. If the naming scheme differs between abundance matrix versus taxonomy table and sample metadata, it is also easy to fix but then we just have to ensure that the order is the same despite the names. |
Dear @TuomasBorman , the pipeline runs successfully for me locally with singularity, however CI tests with docker fail with |
There seems to be an issue with
|
|
@TuomasBorman would you be so kind and check whether the four rds files are fine, i.e. contain what you would expect? Two files produced with |
test/dada2_TreeSummarizedExperiment.rds
test/qiime2_TreeSummarizedExperiment.rds
test_pplace/pplace_TreeSummarizedExperiment.rds
test_pplace/qiime2_TreeSummarizedExperiment.rds
|
Great, thanks. All files look as expected. But the phylogeny potentially can still be added as newick tree from QIIME2. I will test that in the next days. Unfortunately I think it will take until next week to finish this PR. |
Warning Newer version of the nf-core template is available. Your pipeline is using an old version of the nf-core template: 3.0.2. For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation. |
So, finally some progress. @TuomasBorman Could you have a look at the two objects? They should contain now sequences & pylogenetic tree. Also, is the addition inCITATIONS.md fine? |
DADA2 object have reference sequences and both have phylogeny correctly defined. Citation for TreeSE is also correct. --> looks good |
This solves #802 and is based on #805
PR checklist
nf-core pipelines lint
).nextflow run . -profile test,docker --outdir <OUTDIR>
).nextflow run . -profile debug,test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).