Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TreeSummarizedExperiment support #805

Closed
wants to merge 3 commits into from

Conversation

TuomasBorman
Copy link

@TuomasBorman TuomasBorman commented Nov 22, 2024

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/ampliseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

Hello!

This PR is related to this issue: #802

Good news is that I found some time to check this thing. Bad news is that I lack sufficient expertise in both ampliseq and Nextflow to successfully lead the effort to implement TreeSE support.

I realized it would be far more efficient if I had more guidance or, ideally, if someone with deeper knowledge could integrate the "main" TreeSE construction file into ampliseq.

It's worth noting that TreeSE is very similar to phyloseq, so most of the workflows for constructing phyloseq objects should be reusable for TreeSE. The only unique component is the treesummarizedexperiment.nf file.

If no one else is able to take this forward, I’m willing to contribute my expertise and help bring it to completion.

-Tuomas

Copy link

This PR is against the master branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @TuomasBorman,

It looks like this pull-request is has been made against the TuomasBorman/ampliseq master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the TuomasBorman/ampliseq dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

@d4straub
Copy link
Collaborator

Thanks!
It shouldn't be too complicated to add it into the pipeline if input files are satisfied by the files that are created by the pipeline. In case I find time I'll test it.
In any case, for future work, please work on the dev branch because that is the up to date code. master holds the code of the current release, which had some amendments already.
Best

@d4straub
Copy link
Collaborator

Closing in favor of #807

@d4straub d4straub closed this Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants