Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pyright): use activated virtual environment if possible #3557

Closed
wants to merge 1 commit into from
Closed

fix(pyright): use activated virtual environment if possible #3557

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions lua/lspconfig/configs/pyright.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,21 @@ local function set_python_path(path)
end
end

local python_bin = function(venv)
if vim.fn.has('win32') == 1 then
return venv .. '\\Scripts\\python.exe'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return venv .. '\\Scripts\\python.exe'
return venv .. '/Scripts/python.exe'

end
return venv .. '/bin/python'
end

local try_local_python_path = function()
local venv_path = os.getenv('VIRTUAL_ENV')
if venv_path then
return python_bin(venv_path)
end
return nil
end

return {
default_config = {
cmd = { 'pyright-langserver', '--stdio' },
Expand All @@ -55,6 +70,7 @@ return {
useLibraryCodeForTypes = true,
diagnosticMode = 'openFilesOnly',
},
pythonPath = try_local_python_path(),
},
},
},
Expand Down
Loading