fix(pyright): use activated virtual environment if possible #3557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: Pyright will use system python by default, even if we already have a virtual environment activated. Solution: Check current if VIRTUAL_ENV exists in environment variable, if so, set the default pythonPath with the binary inside.
|
I can't reproduce this. Works fine for me? What version of pyright? |
justinmk
reviewed
Jan 13, 2025
| @@ -40,6 +40,21 @@ local function set_python_path(path) | |||
| end | |||
| end | |||
|
|
|||
| local python_bin = function(venv) | |||
| if vim.fn.has('win32') == 1 then | |||
| return venv .. '\\Scripts\\python.exe' | |||
There was a problem hiding this comment.
Suggested change
| return venv .. '\\Scripts\\python.exe' | |
| return venv .. '/Scripts/python.exe' |
|
I figure out my mistake, sorry for taking your time to check. The problem is I have two different virtual environments in two projects and I forgot to switch when I navigate to the second one. |
Yeah, if the venv is "activated" then $PATH would have been modified, so searching for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Pyright will use system python by default, even if we already have a virtual environment activated.
Solution:
Check current if VIRTUAL_ENV exists in environment variable, if so, set the default pythonPath with the binary inside.