Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added denominator argument for functions registerDynamic and register… #124

Merged
merged 4 commits into from
Oct 28, 2024
Merged

Added denominator argument for functions registerDynamic and register… #124

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
600892b
Added denominator argument for functions registerDynamic and register…
elvisboghiu Oct 24, 2024
50a4803
add extra check and unit tests
popenta Oct 25, 2024
1c03892
add docstring for methods
popenta Oct 25, 2024
84f3b10
remove invalid docstring
popenta Oct 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions multiversx_sdk/core/transactions_factories/token_management_transactions_factory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -893,6 +893,7 @@ def create_transaction_for_nft_metadata_recreate(self,
def create_transaction_for_changing_token_to_dynamic(self,
sender: IAddress,
token_identifier: str) -> Transaction:
"""The following token types cannot be changed to dynamic: FungibleESDT, NonFungibleESDT, NonFungibleESDTv2"""
parts: list[str] = [
"changeToDynamic",
arg_to_string(token_identifier)
Expand All @@ -911,6 +912,7 @@ def create_transaction_for_changing_token_to_dynamic(self,
def create_transaction_for_updating_token_id(self,
sender: IAddress,
token_identifier: str) -> Transaction:
"""The following token types cannot be changed to dynamic: FungibleESDT, NonFungibleESDT, NonFungibleESDTv2"""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not correct here for updateTokenID

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's taken from the docs:
https://docs.multiversx.com/tokens/nft-tokens/#update-token

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is wrong in docs, there is already an open PR for this https://github.com/multiversx/mx-docs/pull/1003/files

parts: list[str] = [
"updateTokenID",
arg_to_string(token_identifier)
Expand Down
Loading