Added denominator argument for functions registerDynamic and register… #124
Conversation
…AndSetAllRolesDynamic
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
| def create_transaction_for_changing_token_to_dynamic(self, | ||
| sender: IAddress, | ||
| token_identifier: str) -> Transaction: | ||
| parts: List[str] = [ |
There was a problem hiding this comment.
we can also add an additional check here, we cannot change nft token to dynamic
There was a problem hiding this comment.
we are not able to know token type at this point, but at least add a comment here for this
There was a problem hiding this comment.
that is right but we do not have token type as a parameter here.
| @@ -911,6 +912,7 @@ def create_transaction_for_changing_token_to_dynamic(self, | |||
| def create_transaction_for_updating_token_id(self, | |||
| sender: IAddress, | |||
| token_identifier: str) -> Transaction: | |||
| """The following token types cannot be changed to dynamic: FungibleESDT, NonFungibleESDT, NonFungibleESDTv2""" | |||
There was a problem hiding this comment.
this is not correct here for updateTokenID
There was a problem hiding this comment.
it's taken from the docs:
https://docs.multiversx.com/tokens/nft-tokens/#update-token
There was a problem hiding this comment.
it is wrong in docs, there is already an open PR for this https://github.com/multiversx/mx-docs/pull/1003/files
Added denominator argument for functions registerDynamic and registerAndSetAllRolesDynamic
https://docs.multiversx.com/tokens/nft-tokens#register-dynamic-token
https://docs.multiversx.com/tokens/nft-tokens#register-and-set-all-roles-to-dynamic