[MM-55261] Allow embedded video links to go fullscreen after a permission check #2905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinbinnie
added
2: Dev Review
marianunez
reviewed
Nov 8, 2023
| // is the requesting url trusted? | ||
| if (!(isTrustedURL(parsedURL, serverURL) || (permission === 'media' && parsedURL.origin === serverURL.origin))) { | ||
| if (!(isTrustedURL(parsedURL, serverURL) || (permission === 'media' && parsedURL.origin === serverURL.origin) || isExternalFullscreen)) { |
There was a problem hiding this comment.
Do we want to ask permission or not for external full screen? Is this supposed to be !isExternalFullscreen?
There was a problem hiding this comment.
We do, there's an additional ! at the beginning of that statement.
There was a problem hiding this comment.
Ah gotcha, didn't see that it was added in the two parenthesis there
marianunez
approved these changes
Nov 8, 2023
larkox
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When adding per-server permissions, I neglected to test for YouTube and other embedded videos that will want to fullscreen the app. Those requests always come from the video's source and would get auto-denied otherwise.
This PR adds an exception for the
fullscreenpermission to allow the user to decide whether to allow/deny the full screen permission, which allows these embedded videos to work again.Ticket Link
https://mattermost.atlassian.net/browse/MM-55261