[MM-55261] Allow embedded video links to go fullscreen after a permis…

…sion check (#2905)
mattermost · Nov 10, 2023 · a107127 · a107127
1 parent 7aed1eb
commit a107127
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/src/main/permissionsManager.ts b/src/main/permissionsManager.ts
@@ -105,13 +105,17 @@ export class PermissionsManager extends JsonFileManager<Permissions> {
             return false;
         }
 
+        // Exception for embedded videos such as YouTube
+        // We still want to ask permission to do this though
+        const isExternalFullscreen = permission === 'fullscreen' && parsedURL.origin !== serverURL.origin;
+
         // is the requesting url trusted?
-        if (!(isTrustedURL(parsedURL, serverURL) || (permission === 'media' && parsedURL.origin === serverURL.origin))) {
+        if (!(isTrustedURL(parsedURL, serverURL) || (permission === 'media' && parsedURL.origin === serverURL.origin) || isExternalFullscreen)) {
             return false;
         }
 
         // For certain permission types, we need to confirm with the user
-        if (authorizablePermissionTypes.includes(permission)) {
+        if (authorizablePermissionTypes.includes(permission) || isExternalFullscreen) {
             const currentPermission = this.json[parsedURL.origin]?.[permission];
 
             // If previously allowed, just allow