-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSC4095: Bundled URL previews #4095
Open
tulir
wants to merge
13
commits into
matrix-org:main
Choose a base branch
from
beeper:bundled-url-previews
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+319
−0
Open
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
7eeb3ea
Proposal for bundling URL previews in events
tulir 96a4800
Add examples and mention extensible events
tulir 25e633a
Add note about why `matched_url` is unprefixed in unstable prefixes
tulir 91c8cf1
Fix some HTML tags
tulir 935e36a
Fix security considerations heading size
tulir a51df1a
Add another example and fix some typos
tulir 9ac1336
Add section about original URL preview design doc
tulir 6efebbc
Mention possibility to extend /preview_url for persistent mxcs
tulir 07b8ed7
Mention msgtypes
tulir 6e3d0f1
Clarify behavior of ignoring embedded preview data
tulir 2a94957
Add more security considerations
tulir fa0e094
Mention privacy-preserving TCP relays
tulir b638a9e
Address @zecakeh's review comments
tulir File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe that shouldn't be the case though? the field is called
matched_urls
, which would indicate they need to match something. I'd add that a client might only show previews it also finds a match in the text/markup for? This would also fix the moderation-can't-see-it-issue listed below.