MSC4095: Bundled URL previews #4095
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tulir Asokan <[email protected]>
turt2live
added
proposal
uhoreg
reviewed
Feb 1, 2024
Signed-off-by: Tulir Asokan <[email protected]>
Signed-off-by: Tulir Asokan <[email protected]>
Signed-off-by: Tulir Asokan <[email protected]>
Signed-off-by: Tulir Asokan <[email protected]>
Signed-off-by: Tulir Asokan <[email protected]>
clokep
reviewed
Feb 1, 2024
clokep
reviewed
Feb 1, 2024
Signed-off-by: Tulir Asokan <[email protected]>
Signed-off-by: Tulir Asokan <[email protected]>
Signed-off-by: Tulir Asokan <[email protected]>
Signed-off-by: Tulir Asokan <[email protected]>
ara4n
reviewed
Feb 20, 2024
Signed-off-by: Tulir Asokan <[email protected]>
Johennes
reviewed
Sep 30, 2024
Signed-off-by: Tulir Asokan <[email protected]>
zecakeh
reviewed
Oct 21, 2024
zecakeh
reviewed
Oct 21, 2024
zecakeh
reviewed
Oct 21, 2024
Signed-off-by: Tulir Asokan <[email protected]>
gnunicorn
reviewed
Nov 21, 2024
Comment on lines
+34
to
+35
| Allowing the omission of `matched_url` is effectively a new feature to send URL | ||
| previews without a link in the message text. |
There was a problem hiding this comment.
maybe that shouldn't be the case though? the field is called matched_urls, which would indicate they need to match something. I'd add that a client might only show previews it also finds a match in the text/markup for? This would also fix the moderation-can't-see-it-issue listed below.
sumnerevans
added a commit
to sumnerevans/gomuks
that referenced
this pull request
Dec 20, 2024
This commit implements rending of MSC4095[1] bundled URL previews. [1]: matrix-org/matrix-spec-proposals#4095 Signed-off-by: Sumner Evans <[email protected]>
sumnerevans
added a commit
to sumnerevans/gomuks
that referenced
this pull request
Dec 20, 2024
This commit implements rending of MSC4095[1] bundled URL previews. [1]: matrix-org/matrix-spec-proposals#4095 Signed-off-by: Sumner Evans <[email protected]>
sumnerevans
added a commit
to sumnerevans/gomuks
that referenced
this pull request
Dec 21, 2024
This commit implements rending of MSC4095[1] bundled URL previews. [1]: matrix-org/matrix-spec-proposals#4095 Signed-off-by: Sumner Evans <[email protected]>
sumnerevans
added a commit
to sumnerevans/gomuks
that referenced
this pull request
Dec 21, 2024
This commit implements rending of MSC4095[1] bundled URL previews and includes a preference for disabling rendering of the previews. [1]: matrix-org/matrix-spec-proposals#4095 Signed-off-by: Sumner Evans <[email protected]>
tulir
removed
the
needs-implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendered
Implementations:
/preview_urlendpoint.Signed-off-by: Tulir Asokan [email protected]