Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Element-R: check persistent room list for encryption config #4035

Merged
merged 4 commits into from
Jan 26, 2024
Merged

Element-R: check persistent room list for encryption config #4035

merged 4 commits into from
Jan 26, 2024

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Jan 26, 2024 •
edited by github-actions bot
Loading

We want to make sure that servers are not sneakily hiding or changing encryption configuration settings, which we do by persisting the encryption settings to the crypto store.

Suggest review commit-by-commit.

Here's what your changelog entry will look like:

✨ Features

  • Element-R: check persistent room list for encryption config (#4035).

@richvdh
crypto.spec: make keyResponder a local var
baca39e 
it is never used between functions, so making it external was confusing
@richvdh
Persist encryption state to the rust room list.
01576ee
@richvdh
MatrixClient.shouldEncryptEventForRoom: fix for rust crypto
6e7e295 
Previously, we were not bothering to ask the Rust Crypto stack if it thought we
should be encrypting for a given room. This adds a new method to `CryptoApi`,
wires it up for legacy and Rust crypto, and calls it.
@richvdh
Tests for persistent room list
3b27e13
@richvdh richvdh requested review from a team as code owners January 26, 2024 12:23
andybalaam
andybalaam approved these changes Jan 26, 2024
View reviewed changes
Copy link
Member

@andybalaam andybalaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@richvdh richvdh added this pull request to the merge queue Jan 26, 2024
Merged via the queue into develop with commit 11348f9 Jan 26, 2024
28 checks passed
@richvdh richvdh deleted the rav/element-r/room_list/work branch January 26, 2024 13:04
@richvdh richvdh linked an issue Jan 26, 2024 that may be closed by this pull request
Element R: Persistent room list element-hq/element-web#26108
Closed
5 tasks
@richvdh richvdh mentioned this pull request Jan 26, 2024
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andybalaam andybalaam andybalaam approved these changes

@uhoreg uhoreg Awaiting requested review from uhoreg uhoreg is a code owner automatically assigned from matrix-org/element-crypto-web-reviewers

@BillCarsonFr BillCarsonFr Awaiting requested review from BillCarsonFr BillCarsonFr is a code owner automatically assigned from matrix-org/element-crypto-web-reviewers

@MidhunSureshR MidhunSureshR Awaiting requested review from MidhunSureshR MidhunSureshR is a code owner automatically assigned from matrix-org/element-web-reviewers

@robintown robintown Awaiting requested review from robintown robintown is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Element R: Persistent room list
2 participants
@richvdh @andybalaam