Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Element R: Persistent room list #26108

Closed
5 tasks done
richvdh opened this issue Sep 4, 2023 · 1 comment · Fixed by matrix-org/matrix-js-sdk#4035
Closed
5 tasks done

Element R: Persistent room list #26108

richvdh opened this issue Sep 4, 2023 · 1 comment · Fixed by matrix-org/matrix-js-sdk#4035
Assignees
Labels
O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist Team: Crypto Z-Element-R-Blocker A blocker for enabling Element R by default

Comments

@richvdh
Copy link
Member

richvdh commented Sep 4, 2023

Legacy crypto has a RoomList which maintains a list of encrypted rooms inside the CryptoStore. We probably need to do something with this (otherwise the server could trick us into resetting the encryption settings of a room).

(https://docs.google.com/document/d/18LuSmlaoeZpsOsiPKIdAxKYsbr9V1etMAYm2vxMId7A/edit#heading=h.t75m7z578qe4)

@richvdh richvdh changed the title Persistent room list Element R: Persistent room list Sep 4, 2023
@andybalaam andybalaam added S-Minor Impairs non-critical functionality or suitable workarounds exist O-Uncommon Most users are unlikely to come across this or unexpected workflow Team: Crypto labels Sep 8, 2023
@BillCarsonFr BillCarsonFr added the Z-Element-R-Blocker A blocker for enabling Element R by default label Nov 8, 2023
@andybalaam andybalaam self-assigned this Dec 6, 2023
@andybalaam
Copy link
Member

andybalaam commented Dec 6, 2023

The RoomList module is referred to as matrix-js-sdk/src/crypto/RoomList in matrix-react-sdk. The RoomList class is not actually used, but IRoomEncryption from that module is used.

I am wondering whether we should deprecate RoomList (or really deprecate the fact that it is public?) since we want to make it more of an implementation detail of the crypto.

@andybalaam andybalaam removed their assignment Dec 14, 2023
@richvdh richvdh self-assigned this Jan 10, 2024
richvdh added a commit to matrix-org/matrix-rust-sdk-crypto-wasm that referenced this issue Jan 25, 2024
richvdh added a commit to matrix-org/matrix-rust-sdk-crypto-wasm that referenced this issue Jan 25, 2024
richvdh added a commit to matrix-org/matrix-rust-sdk-crypto-wasm that referenced this issue Jan 25, 2024
@richvdh richvdh closed this as completed Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist Team: Crypto Z-Element-R-Blocker A blocker for enabling Element R by default
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants