-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Element R: Persistent room list #26108
Closed
5 tasks done
Labels
O-Uncommon
Most users are unlikely to come across this or unexpected workflow
S-Minor
Impairs non-critical functionality or suitable workarounds exist
Team: Crypto
Z-Element-R-Blocker
A blocker for enabling Element R by default
Comments
andybalaam
added
S-Minor
Impairs non-critical functionality or suitable workarounds exist
O-Uncommon
Most users are unlikely to come across this or unexpected workflow
Team: Crypto
labels
Sep 8, 2023
3 tasks
BillCarsonFr
added
the
Z-Element-R-Blocker
A blocker for enabling Element R by default
label
Nov 8, 2023
The I am wondering whether we should deprecate |
This was referenced Jan 19, 2024
richvdh
added a commit
to matrix-org/matrix-rust-sdk-crypto-wasm
that referenced
this issue
Jan 25, 2024
richvdh
added a commit
to matrix-org/matrix-rust-sdk-crypto-wasm
that referenced
this issue
Jan 25, 2024
richvdh
added a commit
to matrix-org/matrix-rust-sdk-crypto-wasm
that referenced
this issue
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
O-Uncommon
Most users are unlikely to come across this or unexpected workflow
S-Minor
Impairs non-critical functionality or suitable workarounds exist
Team: Crypto
Z-Element-R-Blocker
A blocker for enabling Element R by default
Legacy crypto has a
RoomList
which maintains a list of encrypted rooms inside theCryptoStore
. We probably need to do something with this (otherwise the server could trick us into resetting the encryption settings of a room).OlmMachine::{set_,}room_settings
matrix-org/matrix-rust-sdk#3042)MatrixClient.roomList
, and let legacy Crypto instantiate its own. Replace the two references to it insideMatrixClient
with aCryptoBackend.isRoomEncrypted
or similar. (Done in Move roomList out of MatrixClient, into legacy Crypto matrix-org/matrix-js-sdk#3944)MatrixClient.encryptEventIfNeeded
, make sure that the crypto store is checked. (Element-R: check persistent room list for encryption config matrix-org/matrix-js-sdk#4035)(https://docs.google.com/document/d/18LuSmlaoeZpsOsiPKIdAxKYsbr9V1etMAYm2vxMId7A/edit#heading=h.t75m7z578qe4)
The text was updated successfully, but these errors were encountered: