Move roomList out of MatrixClient, into legacy Crypto #3944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbkr
approved these changes
Dec 6, 2023
andybalaam
force-pushed
the
andybalaam/move-roomlist-inside-legacy-crypto
branch
from
d26377f to
cc2bb9e
Compare
richvdh
reviewed
Dec 7, 2023
|
@dbkr the SonarCloud errors are about 2 code smells stating that I am using deprecated APIs. Since this change is 100% in deprecated code, I think that is allowable, so please could you force-merge if you agree? |
|
Why force merge... Just dismiss the alerts as won't fix or false positive.
|
I don't have that button:
|
|
@andybalaam have you tried logging in? The button would not be available to those not logged in. |
Thanks, that fixed it. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of element-hq/element-web#26108
This change is marked as an internal change (Task), so will not be included in the changelog.