Unify datasets part 3 #2295
Merged
Unify datasets part 3 #2295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samtygier-stfc
added
the
rebuild_docker 🐋
samtygier-stfc
force-pushed
the
2199-unify-datasets-3
branch
from
a1394aa to
ca4420b
Compare
samtygier-stfc
removed
the
rebuild_docker 🐋
Merged
samtygier-stfc
force-pushed
the
2199-unify-datasets-3
branch
from
ca4420b to
eb4fc63
Compare
|
Force pushed to nudge the tests |
JackEAllen
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Work on #2199
Needs #2293 merged firstDescription
This merges the constructor of
StrictDatasetintoBaseDataset. This makessampleoptional, so requires some asserts in a few places.Testing
No changes to the tests, all existing tests still pass
Acceptance Criteria
Open a dataset
Documentation
Not yet