Unify datasets part 4 #2310
Merged
Unify datasets part 4 #2310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samtygier-stfc
force-pushed
the
2199-unify-datasets-4
branch
from
3fcc254 to
019e803
Compare
Move tests in too
Autospec mocks are slowing down some of the tests. Also simplifies some code
samtygier-stfc
force-pushed
the
2199-unify-datasets-4
branch
from
019e803 to
d73e2c3
Compare
MikeSullivan7
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Work on #2199
Needs #2295 merged firstDescription
This moves the remaining functionality from
StrictDatasettoBaseDataset.StrictDataset,MixedDatasetare now just aliases forBaseDatasetTesting
All existing tests are still there and pass. New tests added to
BaseDatasetAcceptance Criteria
Open a dataset
Delete a stack from a dataset
Documentation
Not yet