Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Acknowledgment of items #531

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Acknowledgment of items #531

merged 1 commit into from
Nov 21, 2023

Conversation

gdethier
Copy link
Contributor

  • The fix is taken as an opportunity to refactor code and stop using effects to handle extrinsic submission.
  • ExtrinsicSubmissionStateView is introduced to simplify display of LogionChainContext's extrinsicSubmissionState.
  • Calls are submitted directly by components using context's submitCall(call).
  • Submission state is explicitly cleared by calling clearSubmissionState().

logion-network/logion-internal#1078

@gdethier gdethier requested a review from benoitdevos November 21, 2023 14:53
benoitdevos
benoitdevos approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@benoitdevos benoitdevos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job !

@gdethier gdethier merged commit 117b9a3 into main Nov 21, 2023
2 checks passed
@gdethier gdethier deleted the feature/fix-acknowledge branch November 21, 2023 20:24
@gdethier gdethier mentioned this pull request Nov 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoitdevos benoitdevos benoitdevos approved these changes

Assignees

@gdethier gdethier

@benoitdevos benoitdevos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gdethier @benoitdevos