Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix transfer and refactor close #532

Merged
merged 2 commits into from
Nov 22, 2023
Merged

Fix transfer and refactor close #532

merged 2 commits into from
Nov 22, 2023

Conversation

gdethier
Copy link
Contributor

  • Apply approach described in Acknowledgment of items #531 to LOC closing and token transfer
  • Implement transaction polling in CommonContext in order to eventually remove TransactionConfirmation component (see token transfer for an illustration)

@gdethier gdethier requested a review from benoitdevos November 22, 2023 13:22
benoitdevos
benoitdevos approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@benoitdevos benoitdevos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job !

@gdethier gdethier merged commit 2455cc0 into main Nov 22, 2023
2 checks passed
@gdethier gdethier deleted the feature/fix-transfer-close branch November 22, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoitdevos benoitdevos benoitdevos approved these changes

Assignees

@gdethier gdethier

@benoitdevos benoitdevos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gdethier @benoitdevos