Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add --include-direct #29

Merged
merged 10 commits into from
Sep 4, 2024
Merged

feat: add --include-direct #29

merged 10 commits into from
Sep 4, 2024

Conversation

joneugster
Copy link
Collaborator

No description provided.

@joneugster
Copy link
Collaborator Author

joneugster commented Aug 30, 2024

With the current logic there might be arrows between these first-degree imports if they directly import each other, but there are no arrows if one indirectly imports another...

Idk if that's just noise we can accept. I have the impression that drawing the indirect imports between these first-degree dependencies might be too complicated and not worth the effort.

EDIT: With the last edit they are filtered out: Nodes included via --include-direct have their dependencies stripped completely.

ImportGraph/Cli.lean Outdated Show resolved Hide resolved
Main.lean Outdated Show resolved Hide resolved
@joneugster
Copy link
Collaborator Author

joneugster commented Sep 2, 2024

Image 1: --mark-module (pointless on its own)
mark-module

Image 2: --mark-module --include-direct
include-direct-deps

Image 3: --mark-module --include-deps
include-deps

Image 4: --mark-module --include-direct --include-deps
include-both

Image 5: --include-direct
include-unmarked

@joneugster joneugster changed the title feat: add directly imported deps to --mark-module feat: add --include-direct Sep 2, 2024
@joneugster joneugster merged commit 2e20421 into main Sep 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants