Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Artifactory Release Lifecycle Management - Modify release bundle promotion properties #893

Merged
merged 2 commits into from
Feb 1, 2024
Merged

Artifactory Release Lifecycle Management - Modify release bundle promotion properties #893

merged 2 commits into from
Feb 1, 2024

Conversation

RobiNino
Copy link
Contributor

@RobiNino RobiNino commented Jan 31, 2024 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Breaking changes:

  • Changed signature of creation and promotion services.
  • Removed the overwrite_existing_artifacts promotion option that has been decommissioned as of 7.75.0 (both from UI and API).

Improvement:

  • Support for include/exclude repositories in release bundle promotion.

@RobiNino RobiNino added breaking change Automatically generated release notes improvement Automatically generated release notes labels Jan 31, 2024
@RobiNino RobiNino requested review from eyalbe4 and yahavi January 31, 2024 07:42
@RobiNino RobiNino mentioned this pull request Jan 31, 2024
Merged
4 tasks
@RobiNino RobiNino force-pushed the remove-lc-overwrite branch from 22d85ee to e81f0c3 Compare February 1, 2024 11:56
@RobiNino RobiNino changed the title Lifecycle - Remove the decommissioned overwrite property from promotion Lifecycle - Modify release bundle promotion properties Feb 1, 2024
@RobiNino RobiNino added the safe to test Approve running integration tests on a pull request label Feb 1, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 1, 2024
@RobiNino RobiNino added the safe to test Approve running integration tests on a pull request label Feb 1, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 1, 2024
@eyalbe4 eyalbe4 changed the title Lifecycle - Modify release bundle promotion properties Artifactory Release Lifecycle Management - Modify release bundle promotion properties Feb 1, 2024
@RobiNino RobiNino merged commit 82ad9eb into jfrog:dev Feb 1, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyalbe4 eyalbe4 eyalbe4 approved these changes

@yahavi yahavi Awaiting requested review from yahavi

Assignees
No one assigned
Labels
breaking change Automatically generated release notes improvement Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RobiNino @eyalbe4