Skip to content

Commit

Permalink
Remove decommissioned property
Browse files Browse the repository at this point in the history
  • Loading branch information
RobiNino committed Jan 31, 2024
1 parent 07e7f31 commit 22d85ee
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 7 deletions.
3 changes: 1 addition & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2448,8 +2448,7 @@ params.ProjectKey = "project"
params.Async = true

environment := "target-env"
overwrite:=true
resp, err := serviceManager.PromoteReleaseBundle(rbDetails, params, environment, overwrite)
resp, err := serviceManager.PromoteReleaseBundle(rbDetails, params, environment)
```
#### Get Release Bundle Creation Status
Expand Down
4 changes: 2 additions & 2 deletions lifecycle/manager.go
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,9 @@ func (lcs *LifecycleServicesManager) CreateReleaseBundleFromBundles(rbDetails li
return rbService.CreateFromBundles(rbDetails, params, sourceReleaseBundles)
}

func (lcs *LifecycleServicesManager) PromoteReleaseBundle(rbDetails lifecycle.ReleaseBundleDetails, params lifecycle.CreateOrPromoteReleaseBundleParams, environment string, overwrite bool) (lifecycle.RbPromotionResp, error) {
func (lcs *LifecycleServicesManager) PromoteReleaseBundle(rbDetails lifecycle.ReleaseBundleDetails, params lifecycle.CreateOrPromoteReleaseBundleParams, environment string) (lifecycle.RbPromotionResp, error) {
rbService := lifecycle.NewReleaseBundlesService(lcs.config.GetServiceDetails(), lcs.client)
return rbService.Promote(rbDetails, params, environment, overwrite)
return rbService.Promote(rbDetails, params, environment)
}

func (lcs *LifecycleServicesManager) GetReleaseBundleCreationStatus(rbDetails lifecycle.ReleaseBundleDetails, projectKey string, sync bool) (lifecycle.ReleaseBundleStatusResponse, error) {
Expand Down
4 changes: 1 addition & 3 deletions lifecycle/services/promote.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,10 @@ func (p *promoteOperation) getOperationParams() CreateOrPromoteReleaseBundlePara
return p.params
}

func (rbs *ReleaseBundlesService) Promote(rbDetails ReleaseBundleDetails, params CreateOrPromoteReleaseBundleParams, environment string, overwrite bool) (RbPromotionResp, error) {
func (rbs *ReleaseBundlesService) Promote(rbDetails ReleaseBundleDetails, params CreateOrPromoteReleaseBundleParams, environment string) (RbPromotionResp, error) {
operation := promoteOperation{
reqBody: RbPromotionBody{
Environment: environment,
Overwrite: overwrite,
},
rbDetails: rbDetails,
params: params,
Expand All @@ -53,7 +52,6 @@ func (rbs *ReleaseBundlesService) Promote(rbDetails ReleaseBundleDetails, params

type RbPromotionBody struct {
Environment string `json:"environment,omitempty"`
Overwrite bool `json:"overwrite_existing_artifacts,omitempty"`
IncludedRepositoryKeys []string `json:"included_repository_keys,omitempty"`
ExcludedRepositoryKeys []string `json:"excluded_repository_keys,omitempty"`
}
Expand Down

0 comments on commit 22d85ee

Please sign in to comment.