update minimum version to eliminate make compatibility warning #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like there's some stale build issues that we'll probably need to work through. |
|
I didn't hit this doing a local build. Looking at the builder, it seems like specifying the version of clang is the issue. |
|
Agreed for Ubuntu, you can probably just drop the "-9" suffix for g++ and clang in ci.yml . The fedora build looks like it has another issue though around including the allow.hpp file possibly. |
cmake 3.0 came out in June 2014 and seems to be a good new minimum threshold, 2.8 has been removed from the documentation links. https://cmake.org/cmake/help/latest/release/index.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cmake 3.0 came out in June 2014 and seems to be a good new minimum threshold, 2.8 has been removed from the documentation links.