Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake deprecation warning #25

Closed
willie opened this issue Jun 12, 2023 · 4 comments
Closed

cmake deprecation warning #25

willie opened this issue Jun 12, 2023 · 4 comments

Comments

@willie
Copy link
Contributor

willie commented Jun 12, 2023

I've just started using your library (thank you for it), but I thought I would pass along a warning that cmake is giving me now. I think its weird on the part of cmake, but, nevertheless.

CMake Deprecation Warning at build/_deps/cappuccino-src/CMakeLists.txt:1 (cmake_minimum_required):
Compatibility with CMake < 2.8.12 will be removed from a future version of CMake.
Update the VERSION argument <min> value or use a ...<max> suffix to tell
CMake that the project does not need compatibility with older versions.
@willie
Copy link
Contributor Author

willie commented Jun 12, 2023

I should note that if someone else comes along and this project hasn't been updated (I'd file a PR, but I don't know the author's wishes) and they want the warning gone, you can put this line (as a workaround) in front of your FetchContent_Declare:

SET(CMAKE_WARN_DEPRECATED OFF CACHE BOOL "CAPPUCCINO_BUILD_TESTS" FORCE)

@jbaldwin
Copy link
Owner

Hey, thanks for opening an issue and glad you're liking the library. Would you be willing to open a PR to fix the warning?

@willie
Copy link
Contributor Author

willie commented Jun 13, 2023

Sure, I'll do that.

@willie
Copy link
Contributor Author

willie commented Jun 13, 2023

Pull request filed #26

@willie willie closed this as completed Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants