Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Helm charts to use secret instead of password. #15

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Change Helm charts to use secret instead of password. #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/xrd-common/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,4 @@ keywords:
- xrd
sources:
- https://github.com/ios-xr/xrd-helm
version: 1.0.3
version: 1.0.4
2 changes: 1 addition & 1 deletion charts/xrd-common/templates/_config-configmap.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ data:
username {{ .Values.config.username }}
group root-lr
group cisco-support
password {{ .Values.config.password }}
secret {{ .Values.config.password }}
!
{{- end }}
{{- if (get .Values.config "ascii") }}
Expand Down
4 changes: 2 additions & 2 deletions charts/xrd-control-plane/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ keywords:
- xrd
sources:
- https://github.com/ios-xr/xrd-helm
version: 1.0.3
version: 1.0.4
dependencies:
- name: xrd-common
version: 1.0.3
version: 1.0.4
repository: "file://../xrd-common"
4 changes: 2 additions & 2 deletions charts/xrd-vrouter/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ keywords:
- xrd
sources:
- https://github.com/ios-xr/xrd-helm
version: 1.0.5
version: 1.0.6
dependencies:
- name: xrd-common
version: 1.0.3
version: 1.0.4
repository: "file://../xrd-common"
2 changes: 1 addition & 1 deletion tests/ut/xrd-control-plane/configmap.bats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ setup_file () {
@test "Control Plane ConfigMap: Startup config can be set using username and password" {
template --set 'config.username=foo' --set 'config.password=bar'
assert_query_equal '.data."startup.cfg"' \
"username foo\n group root-lr\n group cisco-support\n password bar\n!"
"username foo\n group root-lr\n group cisco-support\n secret bar\n!"
}

@test "Control Plane ConfigMap: password must be set if username is" {
Expand Down
2 changes: 1 addition & 1 deletion tests/ut/xrd-vrouter/configmap.bats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ setup_file () {
@test "vRouter ConfigMap: Startup config can be set using username and password" {
template --set 'config.username=foo' --set 'config.password=bar'
assert_query_equal '.data."startup.cfg"' \
"username foo\n group root-lr\n group cisco-support\n password bar\n!"
"username foo\n group root-lr\n group cisco-support\n secret bar\n!"
}

@test "vRouter ConfigMap: password must be set if username is" {
Expand Down
Loading