Change Helm charts to use secret instead of password. #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjohnes
reviewed
Sep 17, 2024
| @@ -18,7 +18,7 @@ data: | |||
| username {{ .Values.config.username }} | |||
| group root-lr | |||
| group cisco-support | |||
| password {{ .Values.config.password }} | |||
| secret {{ include "xrd.hasSecret" . }} | |||
There was a problem hiding this comment.
RP/0/RP0/CPU0:ios(config-un)#secret ?
0 Specifies a cleartext password will follow
10 Specifies that SHA512-based password will follow
8 Specifies that SHA256-based password will follow
9 Specifies that Scrypt-based password will follow
LINE The cleartext user password
Given that we are using the LINE version of the secret configuration - i.e. the user enters a cleartext password - is there any need to deprecated .Values.config.password? We can just change this to configure secret rather than password.
There was a problem hiding this comment.
My feeling was that it could be confusing to have the word "password" in Helm when the actual config is "secret", given that password also exists as config.
There was a problem hiding this comment.
On reflection, I don't think the complication of allowing both is worth it, have changed PR to just use secret.
ebeaty-cisco
force-pushed
the
dev/ebeaty_add_secret
branch
from
465c97a to
be6573c
Compare
tjohnes
approved these changes
Sep 24, 2024
ebeaty-cisco
added a commit
that referenced
this pull request
Dec 19, 2024
Co-authored-by: ebeaty-cisco <[email protected]>
ebeaty-cisco
added a commit
that referenced
this pull request
Dec 19, 2024
…P and vRouter MGMT interfaces (#21) * Add additional cpuset options (#13) * Fix cpu count env var error (#14) * just change password to secret (#15) * added sriov for cp interfaces * added tests that XR_NETWORK_STATUS_ANNOTATION_PATH is not present * added sriov for cp mgmt interfaces * sriov mgmt interfaces added for vrouter * fixed anySRIOV bug * small ut fix * markups --------- Co-authored-by: ebeaty-cisco <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
passwordXR config is being deprecated in favour ofsecret. Update the Helm charts to usesecretinstead ofpassword.UT written for all changes
Tested manually on vRouter and Control Plane images (XR version 7.7).