Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update packages versions for scheduled build #330

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open
2 changes: 2 additions & 0 deletions .github/workflows/scheduled.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,8 @@ jobs:
strategy: ${{ matrix.test-strategy }}
additional-env-vars: |
PKG_SYSREQS_DRY_RUN=true
extra-deps: |
MultiAssayExperiment (>= 1.32.0);SummarizedExperiment (>= 1.36.0);teal.slice (>= 0.5.1.9021)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is interesting as teal.goshawk has nothing to do with MAE and SE packages

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gogonzo extra-deps is the parameter for packages that have nothing to do with the original package.
extra-deps is for the second or for the third level dependencies

teal.goshawk -> teal -> teal.slice -> MultiAssayExperiment, SummarziedExperiment

If you want to specify min version of a 3rd level dependency and you don't want to put it inside DESCRIPTION file, this is the way to go. We discussed this with @pawelru here insightsengineering/teal#1445 (comment)

m7pr marked this conversation as resolved.
Show resolved Hide resolved
branch-cleanup:
if: >
github.event_name == 'schedule' || (
Expand Down
22 changes: 11 additions & 11 deletions DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ Depends:
goshawk (>= 0.1.18),
R (>= 3.6),
shiny (>= 1.6.0),
teal (>= 0.15.2.9079),
teal.transform (>= 0.5.0.9015)
teal (>= 0.15.2.9103),
teal.transform (>= 0.5.0.9021)
Imports:
checkmate (>= 2.1.0),
colourpicker,
Expand All @@ -47,28 +47,28 @@ Imports:
shinyjs,
shinyvalidate,
stats,
teal.code (>= 0.5.0.9012),
teal.logger (>= 0.3.0.9003),
teal.reporter (>= 0.2.0),
teal.widgets (>= 0.4.0)
teal.code (>= 0.5.0.9022),
teal.logger (>= 0.3.0.9004),
teal.reporter (>= 0.3.1.9023),
teal.widgets (>= 0.4.2.9025)
Suggests:
knitr (>= 1.42),
nestcolor (>= 0.1.0),
rmarkdown (>= 2.23),
rvest (>= 1.0.0),
shinytest2,
shinytest2 (>= 0.3.2),
stringr (>= 1.4.1),
teal.data (>= 0.6.0.9015),
tern (>= 0.7.10),
testthat (>= 3.0.4),
teal.data (>= 0.6.0.9025),
tern (>= 0.9.7),
testthat (>= 3.2.0),
utils
VignetteBuilder:
knitr,
rmarkdown
Remotes:
insightsengineering/goshawk
Config/Needs/verdepcheck: insightsengineering/goshawk, rstudio/shiny,
insightsengineering/teal, insightsengineering/teal.transform,
insightsengineering/teal, insightsengineering/teal.slice, insightsengineering/teal.transform,
mllg/checkmate, daattali/colourpicker, tidyverse/dplyr, rstudio/DT,
tidyverse/ggplot2, r-lib/lifecycle, r-lib/rlang, daattali/shinyjs,
rstudio/shinyvalidate, insightsengineering/teal.code,
Expand Down
4 changes: 2 additions & 2 deletions man/tm_g_gh_boxplot.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions man/tm_g_gh_correlationplot.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions man/tm_g_gh_density_distribution_plot.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions man/tm_g_gh_lineplot.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions man/tm_g_gh_scatterplot.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions man/tm_g_gh_spaghettiplot.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading