-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update packages versions for scheduled build #330
base: main
Are you sure you want to change the base?
Conversation
Merge branch 'main' of https://github.com/insightsengineering/teal.goshawk # Conflicts: # R/tm_g_gh_boxplot.R
Merge branch 'main' of https://github.com/insightsengineering/teal.goshawk # Conflicts: # R/tm_g_gh_boxplot.R
Unit Tests Summary 1 files 1 suites 58s ⏱️ Results for commit 2d67b57. ♻️ This comment has been updated with latest results. |
Unit Test Performance Difference
Results for commit e034671 ♻️ This comment has been updated with latest results. |
2 dependency tests fixed. Updating testthat to fix the 3rd one https://github.com/insightsengineering/teal.goshawk/actions/runs/12883188382 |
.github/workflows/scheduled.yaml
Outdated
extra-deps: | | ||
MultiAssayExperiment (>= 1.32.0);SummarizedExperiment (>= 1.36.0);teal.slice (>= 0.5.1.9021) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is interesting as teal.goshawk
has nothing to do with MAE and SE packages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gogonzo extra-deps is the parameter for packages that have nothing to do with the original package.
extra-deps is for the second or for the third level dependencies
teal.goshawk -> teal -> teal.slice -> MultiAssayExperiment, SummarziedExperiment
If you want to specify min version of a 3rd level dependency and you don't want to put it inside DESCRIPTION file, this is the way to go. We discussed this with @pawelru here insightsengineering/teal#1445 (comment)
Specified shinytest2 version and rerunning the build https://github.com/insightsengineering/teal.goshawk/actions/runs/12908665973 |
@llrs-roche would you mind taking a look? I fixed all dependency tests (besides release ofc). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just one comment regarding the Bioconductor dependencies.
I am also surprised that testthat 3.20 works here instead of requiring 3.2.2 for the problems we had with rlang and withr in other checks.
Co-authored-by: Lluís Revilla <[email protected]>
@@ -38,6 +38,8 @@ jobs: | |||
strategy: ${{ matrix.test-strategy }} | |||
additional-env-vars: | | |||
PKG_SYSREQS_DRY_RUN=true | |||
extra-deps: | | |||
matrixStats (>= 1.5.0);teal.slice (>= 0.5.1.9021) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we may be able to remove teal.slice
from here, once this is merged https://github.com/insightsengineering/teal/pull/1461/files
Rerunning after the relaxation of assumptions on bioconductor packages versions https://github.com/insightsengineering/teal.goshawk/actions/runs/12932596927 |
Part of insightsengineering/nestdevs-tasks#98
Build https://github.com/insightsengineering/teal.goshawk/actions/runs/12882792248