Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workflow #64

Merged
merged 89 commits into from
Nov 22, 2024
Merged

Workflow #64

merged 89 commits into from
Nov 22, 2024

Conversation

gidden
Copy link
Member

@gidden gidden commented Aug 18, 2023 •
edited
Loading

Includes #58 and #59 and #60

gidden and others added 30 commits March 30, 2023 09:39
@gidden
add ptolemy as a dep
f0ebf55
@gidden
add initial gridding routine
2c803de
@gidden
some clean up with remaining iso col
53131c8
@gidden
stickler
d4ca804
@gidden
update for xarray reqs
83e8c6c
@gidden
add example notebook
00d96f2
@gidden
add docstrings for grid
2bd9a28
@gidden
add docstring for check_coord_overalp
32a0051
@gidden
update xlsxwriter save -> close
c5cab38
@gidden
add plots in notebook
338a277
@coroa
Add downscaling module
bca3416
@coroa
Improve harmonization bits with pandas_indexing
3f26663
@coroa
Extend harmonization method selection to downscaling
8b421ab
@coroa
Add method selection to downscaling
1b8e20e
@coroa
Add proxy checking
82452d3
@coroa
Create downscaling context early
fc5a8c1
@coroa
Fix downscaling methods
676309a
@coroa
Make linter happy
4813d93
@coroa
Fix tox typo
588c6b5
@coroa
Add simple_proxy downscaling method
f05c1e1
@coroa
Revise how arguments to default_methods are handled
e55f1d2
@coroa
Fix ExcelWriter usage
73b1659
@coroa
Merge branch 'pr/gidden/58' into workflow
edfb273
@coroa
Fix pandas-indexing imports
22f9ceb
@coroa
grid: Generalize check_coord_overlap
23c0073
@coroa
Add Gridder
9aff824
@coroa
Assume years as integers
6567c37
@coroa
fix(intensity_convergence): Avoid creating duplicates
2d6581c
@coroa
Add semijoin call into where to help pandas
90d7526
@coroa
fix(downscaling): Cope with zero model emissions in intensity converg…
f79fcee 
…ence
@coroa coroa mentioned this pull request Feb 22, 2024
Merged
@coroa
Copy link
Collaborator

coroa commented Feb 22, 2024

Ok, except that we did not update any documentation or tests, this PR should be good to go.

@coroa
Copy link
Collaborator

coroa commented Feb 22, 2024

Ah, the new grid module we introduce here is effectively not used anymore by concordia. We could take a look into concordias grid-module and think whether we want to move some of that into aneris.

The main problem is that i was very liberal in the use of VariableDefinitions intricacies that i am not sure we want to have directly in here. So maybe easiest to just remove the current module from aneris and then re-add something on a subsequent push.

@gidden
Copy link
Member Author

gidden commented Mar 20, 2024

Lack of tests is blocking this merge for now

@coroa coroa mentioned this pull request Mar 21, 2024
Merged
@gidden gidden merged commit 2bd6250 into main Nov 22, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gidden @codecov-commenter @coroa