PR for Review Round 1 #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
gidden
commented
Oct 11, 2023
•
gidden
commented
- update filenames
- shipping proxies updated to MariTeam (in gridding prep repo)
- CDR proxies updated (daccs, industry, and OAE)
- regress f-gas split
gidden
commented
Oct 13, 2023
Base of Review round-2
coroa
force-pushed
the
review/round-1
branch
from
251cb17 to
a460abb
Compare
|
Depends on ptolemy PR: gidden/ptolemy#10 |
Fix sector order and float32 dtype
coroa
changed the title
|
Ok, ceds-gridding proxies are in, they have been updated to the correct dtype and non-alphabetical order. I would like to merge this tomorrow! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.