enh(perl) fix false-positive variable match at end of string (plus test)

CHANGES.md

@@ -2,6 +2,7 @@
 
 Core Grammars:
 
+- enh(perl) fix false-positive variable match at end of string [Josh Goebel][]
 - fix(cpp) not all kinds of number literals are highlighted correctly [Lê Duy Quang][]
 - fix(css) fix overly greedy pseudo class matching [Bradley Mackey][]
 - enh(arcade) updated to ArcGIS Arcade version 1.24 [Kristian Ekenes][]
@@ -43,6 +44,7 @@ Themes:
 [Robloxian Demo]: https://github.com/RobloxianDemo
 [Paul Tsnobiladzé]: https://github.com/tsnobip
 [Jonah Jeleniewski]: https://github.com/cirras
+[Josh Goebel]: https://github.com/joshgoebel
 [CY Fung]: https://github.com/cyfung1031
 [Vitaly Barilko]: https://github.com/Diversus23
 

src/languages/perl.js

@@ -270,15 +270,15 @@ export default function(hljs) {
     variants: [
       { begin: /\$\d/ },
       { begin: regex.concat(
-        /[$%@](\^\w\b|#\w+(::\w+)*|\{\w+\}|\w+(::\w*)*)/,
+        /[$%@](?!")(\^\w\b|#\w+(::\w+)*|\{\w+\}|\w+(::\w*)*)/,
         // negative look-ahead tries to avoid matching patterns that are not
         // Perl at all like $ident$, @ident@, etc.
         `(?![A-Za-z])(?![@$%])`
         )
       },
       {
         // Only $= is a special Perl variable and one can't declare @= or %=.
-        begin: /[$%@][^\s\w{=]|\$=/,
+        begin: /[$%@](?!")[^\s\w{=]|\$=/,
         relevance: 0
       }
     ],

test/markup/perl/default.expect.txt

@@ -25,6 +25,10 @@
   <span class="hljs-comment"># GH-117</span>
   <span class="hljs-keyword">my</span> <span class="hljs-variable">$g</span> = <span class="hljs-keyword">glob</span>(<span class="hljs-string">&quot;/usr/bin/*&quot;</span>);
 
+  <span class="hljs-comment"># GH-3934</span>
+  <span class="hljs-keyword">print</span> <span class="hljs-string">&quot;@&quot;</span>;
+  <span class="hljs-keyword">print</span>;
+
   <span class="hljs-keyword">return</span> <span class="hljs-variable">$o</span>;
 }
 

test/markup/perl/default.txt

@@ -25,6 +25,10 @@ sub load
   # GH-117
   my $g = glob("/usr/bin/*");
 
+  # GH-3934
+  print "@";
+  print;
+
   return $o;
 }