Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh(perl) fix false-positive variable match at end of string (plus test) #3943

Conversation

h3xx
Copy link
Contributor

@h3xx h3xx commented Dec 16, 2023

See #3934 for a full description of this issue.

Includes work from @joshgoebel who hasn't been seen online since 2023-12-01, may he rest in peace, j/k :-)

This PR is basically the same as #3935, except it also adds a markup test for the issue I described in #3934.

Changes

Fixes #3934
Closes #3935

Checklist

  • Added markup tests (@h3xx did this)
  • Updated the changelog at CHANGES.md (@joshgoebel did this)

@h3xx h3xx changed the title enh(perl) fix false-positive variable match at end of string enh(perl) fix false-positive variable match at end of string (plus test) Dec 16, 2023
Copy link

Build Size Report

Changes to minified artifacts in /build, after gzip compression.

1 Removed File

View Changes
file size
styles/1c-light.min.css -554 B

12 files changed

Total change -139 B

View Changes
file base pr diff
es/languages/1c.min.js 14.23 KB 14.18 KB -48 B
es/languages/bash.min.js 1.6 KB 1.6 KB -4 B
es/languages/javascript.min.js 2.73 KB 2.71 KB -17 B
es/languages/perl.min.js 2.02 KB 2.02 KB +8 B
es/languages/swift.min.js 3.54 KB 3.54 KB +7 B
es/languages/typescript.min.js 3.15 KB 3.14 KB -16 B
languages/1c.min.js 14.23 KB 14.18 KB -48 B
languages/bash.min.js 1.61 KB 1.61 KB -4 B
languages/javascript.min.js 2.74 KB 2.72 KB -17 B
languages/perl.min.js 2.02 KB 2.02 KB +9 B
languages/swift.min.js 3.54 KB 3.55 KB +7 B
languages/typescript.min.js 3.16 KB 3.14 KB -16 B

Copy link

Build Size Report

Changes to minified artifacts in /build, after gzip compression.

2 files changed

Total change +17 B

View Changes
file base pr diff
es/languages/perl.min.js 2.02 KB 2.02 KB +8 B
languages/perl.min.js 2.02 KB 2.02 KB +9 B

@joshgoebel joshgoebel merged commit 10f27ec into highlightjs:main Dec 25, 2023
15 checks passed
@joshgoebel
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(perl) "@" breaks highlighting
2 participants