enh(perl) fix false-positive variable match at end of string #3935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build Size ReportChanges to minified artifacts in 4 files changedTotal change +10 B View Changes
|
|
Can you please pull in d68f081 from my branch? |
h3xx
approved these changes
Dec 16, 2023
There was a problem hiding this comment.
So yeah. This works for me. It would be great if you could also merge or cherry-pick my commit d68f081 that adds a test for my issue:
git remote add h3xx https://github.com/h3xx/highlight.js.git
git fetch h3xx
git merge --ff d68f0814719d1b677deeb551b4a815ef7b13029c
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Resolves #3934.
Checklist
CHANGES.md