Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zig: Downgrade to 0.13 with local LLVM #4844

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Conversation

GZGavinZhao
Copy link
Member

Summary

Bring back Zig from 0.14 snapshot to stable 0.13 release using in-tree LLVM build.

Test Plan

  • Built ghostty
  • Zig x86 test suite all passed.

Checklist

  • Package was built and tested against unstable
  • This change could gainfully be listed in the weekly sync notes once merged

@GZGavinZhao GZGavinZhao mentioned this pull request Jan 17, 2025
2 tasks
@GZGavinZhao
Copy link
Member Author

Last rebuild to see if I can get rid of networking: true.

@GZGavinZhao GZGavinZhao self-assigned this Jan 17, 2025
@GZGavinZhao GZGavinZhao marked this pull request as ready for review January 17, 2025 02:36
@GZGavinZhao GZGavinZhao changed the title zig: Downgrade to 13 with in-tree LLVM zig: Downgrade to 0.13 with in-tree LLVM Jan 17, 2025
@GZGavinZhao GZGavinZhao changed the title zig: Downgrade to 0.13 with in-tree LLVM zig: Downgrade to 0.13 with local LLVM Jan 17, 2025
@GZGavinZhao
Copy link
Member Author

Admittedly it's a little ugly with the export CC and export CMAKE_C_COMPILER_LAUNCHER. We can get rid of that if we don't use clang: yes.

@GZGavinZhao GZGavinZhao merged commit 430bd1a into getsolus:main Jan 17, 2025
1 check passed
@EbonJaeger EbonJaeger added the Topic: Sync Notes This PR/Issue can be highlighted in sync notes label Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Topic: Sync Notes This PR/Issue can be highlighted in sync notes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants