Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ghostty: Add at 1.0.1 #4839

Merged
merged 1 commit into from
Jan 17, 2025
Merged

ghostty: Add at 1.0.1 #4839

merged 1 commit into from
Jan 17, 2025

Conversation

infinitymdm
Copy link
Contributor

@infinitymdm infinitymdm commented Jan 16, 2025

Summary

Add ghostty terminal at 1.0.1. Fixes #4749

Test Plan

  • Launch ghostty and use it as you'd use any terminal
  • Verify that ghostty opens terminal applications such as micro (This is possible, but depends on DE and requires jumping through a bunch of hoops)

Checklist

  • Package was built and tested against unstable
  • This change could gainfully be listed in the weekly sync notes once merged

@GZGavinZhao
Copy link
Member

Probably needs to wait for #4844.

@EbonJaeger EbonJaeger added the Topic: Sync Notes This PR/Issue can be highlighted in sync notes label Jan 17, 2025
Copy link
Member

@davidjharder davidjharder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built and ran fine for me. @infinitymdm can you add your MAINTAINER file, then I think this can go in

@davidjharder davidjharder marked this pull request as ready for review January 17, 2025 15:38
@infinitymdm
Copy link
Contributor Author

Switched to a hashed archive rather than a git tag while I was at it. Works great with Gavin's zig stuff.

Copy link
Member

@davidjharder davidjharder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@davidjharder davidjharder merged commit 22e0623 into getsolus:main Jan 17, 2025
1 check passed
@infinitymdm infinitymdm deleted the add_ghostty branch January 17, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Topic: Sync Notes This PR/Issue can be highlighted in sync notes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

ghostty
4 participants