feat: Add accept_invalid_certs flag to HttpSource
#1405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swatinem
approved these changes
Mar 7, 2024
|
As another NOTE: There is a toggle in the project settings UI specifically for this (on the very bottom):
We noticed this back when we ported JS processing over, where we never implemented this. Noone has complained about this as a matter of fact. 🤷🏻♂️ |
loewenheim
added a commit
to getsentry/sentry
that referenced
this pull request
Mar 8, 2024
This sets the `accept_invalid_certs` flag on the NVIDIA symbol source. This flag was defined on the Symbolicator side in getsentry/symbolicator#1405. Background: we currently can't fetch symbols from the NVIDIA source because we can't verify its SSL certificates. We've added the capacity to skip SSL cert verification to Symbolicator, and this PR enables it for the NVIDIA source. The epic is tracked in getsentry/symbolicator#1402. This is intended as a stopgap until we manage to verify the certificates one way or another.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #1404.
This adds a flag to
HttpSource(parsed asfalseby default, so backwards compatible) that allows downloading from the source even if its SSL certs can't be verified.