Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Mark NVIDIA source as accept_invalid_certs #66509

Merged
merged 5 commits into from
Mar 8, 2024
Merged

Conversation

loewenheim
Copy link
Contributor

This sets the accept_invalid_certs flag on the NVIDIA symbol source. This flag was defined on the Symbolicator side in getsentry/symbolicator#1405.

Background: we currently can't fetch symbols from the NVIDIA source because we can't verify its SSL certificates. We've added the capacity to skip SSL cert verification to Symbolicator, and this PR enables it for the NVIDIA source.

The epic is tracked in getsentry/symbolicator#1402.

This is intended as a stopgap until we manage to verify the certificates one way or another.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 7, 2024
@loewenheim loewenheim self-assigned this Mar 7, 2024
@loewenheim loewenheim requested a review from a team March 7, 2024 15:46
src/sentry/conf/server.py Show resolved Hide resolved
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.30%. Comparing base (a83c6a1) to head (8ff28db).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #66509   +/-   ##
=======================================
  Coverage   84.30%   84.30%           
=======================================
  Files        5311     5311           
  Lines      237373   237373           
  Branches    41062    41062           
=======================================
+ Hits       200121   200127    +6     
+ Misses      37033    37027    -6     
  Partials      219      219           
Files Coverage Δ
src/sentry/conf/server.py 90.18% <ø> (ø)

... and 10 files with indirect coverage changes

Copy link
Member

@Swatinem Swatinem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds perfect

@loewenheim loewenheim merged commit 600febc into master Mar 8, 2024
49 checks passed
@loewenheim loewenheim deleted the nvidia-no-ssl branch March 8, 2024 08:58
@github-actions github-actions bot locked and limited conversation to collaborators Mar 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants