-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref: Mark NVIDIA source as accept_invalid_certs
#66509
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Automatically applied to PRs that change backend components
label
Mar 7, 2024
anonrig
approved these changes
Mar 7, 2024
anonrig
approved these changes
Mar 7, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #66509 +/- ##
=======================================
Coverage 84.30% 84.30%
=======================================
Files 5311 5311
Lines 237373 237373
Branches 41062 41062
=======================================
+ Hits 200121 200127 +6
+ Misses 37033 37027 -6
Partials 219 219
|
Swatinem
approved these changes
Mar 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds perfect
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets the
accept_invalid_certs
flag on the NVIDIA symbol source. This flag was defined on the Symbolicator side in getsentry/symbolicator#1405.Background: we currently can't fetch symbols from the NVIDIA source because we can't verify its SSL certificates. We've added the capacity to skip SSL cert verification to Symbolicator, and this PR enables it for the NVIDIA source.
The epic is tracked in getsentry/symbolicator#1402.
This is intended as a stopgap until we manage to verify the certificates one way or another.