Prepare to publish 0.1.0! #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eyelidlessness
force-pushed
the
chore/npm-scope-getodk
branch
from
492c97b to
6a5cdac
Compare
Closed
12 tasks
eyelidlessness
changed the title
@odk-web-forms NPM scope to @getodk@odk-web-forms NPM scope to @getodk, ui-vue to web-forms
eyelidlessness
force-pushed
the
chore/npm-scope-getodk
branch
from
7f5cf92 to
4fbe91c
Compare
eyelidlessness
force-pushed
the
chore/npm-scope-getodk
branch
from
64e3689 to
5aafe4c
Compare
eyelidlessness
changed the title
@odk-web-forms NPM scope to @getodk, ui-vue to web-formsIn so doing: - Also fix a few copypasta mistakes spotted along the way (references to the wrong package, for the most part) - Apply any applicable auto-formatting (i.e. changes were applied per file and saved so VSCode would apply the appropriate formatting). Note that this has a greater effect in .vue modules, e.g. stripping a bunch of trailing whitespace that hadn’t already been, adding EOF newlines, etc. - Rewrap some text (in .md files) and code comments. This was not done automatically on save, it’s something I currently do while editing comments. As such, I may have missed some, but I tried my best not to leave any new comment formatting weirdness. Also note that there is one remaining reference to the text “odk-web-forms”: this is an older directory name (before we split `xforms-engine` and `ui-solid` packages), in a GitHub permalink, so it’s correct.
This doesn’t affect failure in CI, but it showed up locally while investigating that.
… hopefully.
As decided in this week’s team meetings: - We expect this to be our canonical (first-party) client for filling forms. - It will also be the source package for a custom element wrapper (which will also be built with the underlying Vue UI implementation, but won’t require Vue in host applications). - While we may continue to maintain `ui-solid`, that primarily serves internal purposes for now. We don’t **currently** anticipate providing multiple framework-specific UIs in tandem.
- ODK web forms -> ODK Web Forms - web forms -> forms (where it isn’t a reference to the project) There are a few other references in code comments which are left as-is to avoid adding noise to those source files. We can update them as appropriate.
eyelidlessness
force-pushed
the
chore/npm-scope-getodk
branch
from
5aafe4c to
43c46ff
Compare
I ran This is just an observation, no action is required for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #50. Closes #99. (We decided to go ahead and publish 0.1.0, and address Changesets afterward.)
Also fix a few copypasta mistakes spotted along the way (references to the wrong package in e.g. README prose/instructions/examples, for the most part)
Apply any applicable auto-formatting (i.e. changes were applied per file and saved so VSCode would apply the appropriate formatting). Note that this has a greater effect in .vue modules, e.g. stripping a bunch of trailing whitespace that hadn’t already been, adding EOF newlines, etc.
Rewrap some text (.md files) and code comments. This was not done automatically on save, it’s a manual command I currently run while editing. As such, I may have missed some, but I tried my best not to leave any new formatting weirdness.
Specifies additional criteria for invalidating the install cache in CI. Hopefully this addresses the failure that occurred on the first commit!
Excludes
xforms-enginegenerated API docs from lint. This didn't affect CI, but keeps showing up locally, and showed up again while investigating the CI failure.Also note that there is one remaining reference to the text “odk-web-forms”: this is an older directory name (before we split
xforms-engineandui-solidpackages), in a GitHub permalink, so it’s correct.