Prepare release: @getodk/web-forms 0.3.0
#208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Another commit will follow correcting a few issues I noticed spot checking this.
- Notes support is semver minor - Fix `constraint` typo - Improve formatting of items where changeset was a list
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #204, which I'll close after opening this.
A few quick notes:
I'm not sure how best to title release prep PRs. We're bumping each package's version based on its own semver changes, as determined by that package's outstanding changesets. I wanted to look back at previous release prep PRs and wasn't thrilled by the less specific Prepare release #159; the more specific formats of Prepare to publish 0.1.0! #116 and Prepare 0.1.1 #125 don't make sense when we're releasing different versions per package. I think since
web-formsis generally the package most end-users will use, this PR's title format might be a good one to follow in the future. But open to suggestions!As in xpath: update README to reflect
indexed-repeatsupport #204, I updated thexpathREADME to reflectindexed-repeatsupport. That README section may be better removed, but I want to hold off for the work designed in External secondary instances: Engine representation, XPath support #203. We may want to move XForms functionality out ofxpathaltogether, and intoxforms-engine.I think the feature matrix is up to date. Another pair of eyes to scan it for anything I might have missed would be welcome.
I also added a top-level script to only format the top-level README, and added its invocation to the end of the feature matrix script. It seems kinda goofy to automate part of that process and then leave a little bit of manual followup work to do after the automation is run.
I want to move
feature-matrix.jsoninto the directory with the script that controls it, but held off to ask about it here. Is the intent of having it top-level so that hypothetical contributors outside the ODK team have clear direction for updating it? If so, I think that's a pretty unlikely contribution scenario, but we could move it and then add a symlink at the root.