Provide support for Debian; to uninstall docker and deps #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hesco
changed the title
…tion id'd by travis CI
|
Hi @hesco. Thanks for taking a run at adding Debian support. It's definitely something I'd love the module to have. However, especially as I'm not currently using Debian myself, it's really important to me that the test suite passes for this before it's merged into master. I'm happy to add the integration tests using beaker, but if you could try and get the rest of the test suite passing that would be appreciated. |
Conflicts: manifests/install.pp manifests/service.pp
|
Closing in favour of #151 |
Closed
cegeka-jenkins
pushed a commit
to cegeka/puppet-docker
that referenced
this pull request
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have successfully tested the uninstall functionality (by setting $docker::params::ensure to 'purged'). These changes will purge, or supposedly absent docker (and its dependent packages). Restoring the ::ensure value to 'present' restores the installation successfully. I made no attempt to remove the /etc/apt/sources.list.d/docker.list file nor to purge the apt key, although it seems those two actions would be appropriate if ::ensure is set to 'purged'. That is work for a later day. This functionality was sufficient for running the tests necessary for my work on the feature I am interested in.
I failed to find an init.d script upon reinstall. I am unsure whether that means that no such script exists in the package, or if my conditional wrapper has a bug in it. I will investigate that further after lunch, perhaps. Still need to sort out how to start the docker service on a debian server.
I manually added in:
https://github.com/dotcloud/docker/blob/master/contrib/init/sysvinit-debian/docker
modifying it to ensure that it runs under bash, rather than dash. Should probably contribute that patch upstream.
moby/moby#7031
When that file is incorporated into the docker package, it should be unnecessary to include it here as an explicit File['/etc/init.d/docker'] resource. After some testing I am confident that these changes should successfully ensure => running, enable => true, starting the daemon and populating /etc/rc?.d/*docker.
At this point this PR should resolve #75 and provide useful support for debian servers.
I just added support for the installation and removal of recommended packages, which right now includes only bridge-utils on debian/ubuntu machines. This has been manually tested and found to work, for $docker::params::ensure_recommended being 'present' or 'purged'.
If the Tavis CI server is satisfied, I am now recommending that these changes be exercised with the maintainer's regression suite and merged into the source project.
TODO: