Gh142 support debian #151
Gh142 support debian #151
Conversation
…ian, not to redhat
otherwise unable to get this to build in my debian environment
…2-dev, libxslt1-dev
|
This should resolve #142. It includes some refactoring (new docker::repos and docker::repo::(deb_packages|yum_packages classes) as well as moving some resources about among the classes, some variables into the ::params class. There is still room for more of that sort of clean-up. But this ought to accomplish the initial goal of providing debian support and test coverage for that new functionality. Also added several sanity checks along the way. |
| validate_string($::kernelrelease) | ||
| validate_bool($docker::use_upstream_package_source) | ||
|
|
||
| # $kernelpackage = $docker::param::kernelpackage |
There was a problem hiding this comment.
I think this should be params rather than param
|
He @hesco, this looks great. I've left a few minor comments. I've noticed as well that it won't currently merge cleanly onto master. If it's relatively simple to do if you could rebase that would be great. I'll add Debian to the beaker acceptance tests as well and update the metadata. Thanks again |
…hr-docker into gh142_support_debian Conflicts: manifests/params.pp
| validate_bool($manage_kernel) | ||
| validate_bool($manage_package) | ||
|
|
||
| anchor { 'docker::begin': } -> | ||
| class { 'docker::repos': } -> |
There was a problem hiding this comment.
This change will generate the following error message because the mirror is defined before the package apt-transport-https is installed.
==> default: Notice: /Stage[main]/Apt::Update/Exec[apt_update]/returns: E: The method driver /usr/lib/apt/methods/https could not be found.
|
Hey Gareth: Thanks for cleaning up behind me (#75, #76). I did not miss the above reports related to regression in the acceptance tests, and do plan to address them as soon as I can, but have been slammed all week. Will jump on those as soon as I can unless you get impatient and want to push this work out sooner than I can get to it. -- Hugh |
|
What's the current status of this patch? |
|
I am also interested in this |
|
Master now has Debian support in finally. Thanks for submitting this and apologies for leaving it hanging for ages. |
|
good to hear. Thanks for taking care of that. Have a machine sitting in the living room waiting for me to upgrade its firmware. Perhaps when that is done, I can create a new environment, install the latest version of your module and use it to install docker 1.9. I see that weave has now been integrated with docker. |
No description provided.