Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/remove-deprecated-fields #29

Merged
merged 6 commits into from
Nov 11, 2024
Merged

feature/remove-deprecated-fields #29

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f530110
feature/remove-deprecated-fields
fivetran-catfritz Nov 5, 2024
e75842a
update changelog
fivetran-catfritz Nov 5, 2024
382d8f2
Update CHANGELOG.md
fivetran-catfritz Nov 7, 2024
32d3a1d
Apply suggestions from code review
fivetran-catfritz Nov 9, 2024
f75dc3d
update yml
fivetran-catfritz Nov 9, 2024
b188efc
Update packages.yml
fivetran-catfritz Nov 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,12 @@
# dbt_recurly v0.5.0
[PR #29](https://github.com/fivetran/dbt_recurly/pull/29) includes the following breaking changes:
fivetran-catfritz marked this conversation as resolved.
Show resolved Hide resolved
## Breaking Changes
- Removed unused fields from `stg_recurly__subscription_history` in the upstream `dbt_recurly_source` package (see [release notes](https://github.com/fivetran/dbt_recurly_source/releases/tag/v0.3.0)):
- `converted_at`
- `has_started_with_gift`
- While this change does not directly affect fields in this package’s models, it is classified as a breaking change due to modifications in `stg_recurly__subscription_history`.
- These fields were removed as they are slated for future deprecation in the Fivetran Connector and are not explicitly referenced in the final models.

# dbt_recurly v0.4.0

[PR #26](https://github.com/fivetran/dbt_recurly/pull/26) includes the following breaking changes:
Expand Down
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ Include the following recurly_source package version in your `packages.yml` file
```yaml
packages:
- package: fivetran/recurly
version: [">=0.4.0", "<0.5.0"]
version: [">=0.5.0", "<0.6.0"]
```

Do NOT include the `recurly_source` package in this file. The transformation package itself has a dependency on it and will install the source package as well.
Expand Down Expand Up @@ -151,7 +151,7 @@ This dbt package is dependent on the following dbt packages. These dependencies
```yml
packages:
- package: fivetran/recurly_source
version: [">=0.2.0", "<0.3.0"]
version: [">=0.3.0", "<0.4.0"]

- package: fivetran/fivetran_utils
version: [">=0.4.0", "<0.5.0"]
Expand Down
2 changes: 1 addition & 1 deletion docs/catalog.json
View file
Open in desktop

Large diffs are not rendered by default.

47 changes: 10 additions & 37 deletions docs/index.html
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion docs/manifest.json
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 0 additions & 1 deletion docs/run_results.json
View file
Open in desktop

This file was deleted.

12 changes: 6 additions & 6 deletions integration_tests/seeds/subscription_history_data.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
_fivetran_synced,id,created_at,updated_at,activated_at,canceled_at,expires_at,account_id,plan_id,object,uuid,state,current_period_started_at,current_period_ends_at,current_term_started_at,current_term_ends_at,trial_started_at,trial_ends_at,remaining_billing_cycles,total_billing_cycles,renewal_billing_cycles,auto_renew,paused_at,remaining_pause_cycles,currency,unit_amount,quantity,add_ons_total,subtotal,collection_method,expiration_reason,started_with_gift
2022-07-28 14:59:08,99b1bc4097d247c10c89dc71d41f8046,2019-03-26 09:28:17,2019-03-26 09:37:26,2019-03-26 09:28:17,2019-03-26 09:37:26,2019-03-26 09:37:26,4458762633d912919d7ff692cab13b69,1c85c5b774e9eabf29b9b439b8ee4584,subscription,d2033e289f1823674fd6cb332db6bf5f,expired,2019-03-26 09:28:17,2019-04-26 09:28:17,,2019-04-26 09:28:17,,,,,,true,,,USD,99.0,1,0.0,99.0,manual,canceled,false
2022-07-28 14:59:08,b4110f7673aa3e121abf4ffaad157f62,2019-03-26 09:25:03,2019-03-26 09:27:19,2019-03-26 09:25:03,2019-03-26 09:27:19,2019-03-26 09:27:19,4458762633d912919d7ff692cab13b69,1c85c5b774e9eabf29b9b439b8ee4584,subscription,1f5496fb1572e464194d1f6d41a91707,expired,2019-03-26 09:25:03,2019-04-26 09:25:03,,2019-04-26 09:25:03,,,,,,true,,,USD,99.0,1,0.0,99.0,automatic,canceled,false
2022-08-11 08:21:03,2900cfb1daef789cc21ea100ff6af6e9,2015-02-11 08:20:39,2022-08-11 08:20:39,2015-02-11 08:20:38,,,51bccf87e2571558b3da93688e17469f,1c85c5b774e9eabf29b9b439b8ee4584,subscription,81fe13285947f866c70b8102aa8f231d,active,2022-08-11 08:20:38,2022-09-11 08:20:38,2022-08-11 08:20:38,2022-09-11 08:20:38,,,0,1,1,true,,,USD,99.0,1,0.0,99.0,automatic,,false
2022-07-28 14:59:08,2900cfb1daef789cc21ea100ff6af6e9,2015-02-11 08:20:39,2022-07-11 08:23:42,2015-02-11 08:20:38,,,51bccf87e2571558b3da93688e17469f,1c85c5b774e9eabf29b9b439b8ee4584,subscription,81fe13285947f866c70b8102aa8f231d,active,2022-07-11 08:20:38,2022-08-11 08:20:38,2022-07-11 08:20:38,2022-08-11 08:20:38,,,0,1,1,true,,,USD,99.0,1,0.0,99.0,automatic,,false
2022-08-11 08:21:03,bcd3f1f36bd98895b5336e067049364b,2015-02-13 09:31:52,2022-07-20 09:32:53,2015-02-13 09:31:52,,,4458762633d912919d7ff692cab13b69,455b18e9a39e782da54de395edb6b566,subscription,971038e8a1a99aed7d9972903e0b5219,active,2022-07-20 09:31:52,2022-08-20 09:31:52,2022-07-20 09:31:52,2022-08-20 09:31:52,2015-02-13 09:31:52,2015-02-20 09:31:52,0,1,1,true,,,USD,2999.0,1,2597.0,5596.0,automatic,,false
_fivetran_synced,id,created_at,updated_at,activated_at,canceled_at,expires_at,account_id,plan_id,object,uuid,state,current_period_started_at,current_period_ends_at,current_term_started_at,current_term_ends_at,trial_started_at,trial_ends_at,remaining_billing_cycles,total_billing_cycles,renewal_billing_cycles,auto_renew,paused_at,remaining_pause_cycles,currency,unit_amount,quantity,add_ons_total,subtotal,collection_method,expiration_reason
2022-07-28 14:59:08,99b1bc4097d247c10c89dc71d41f8046,2019-03-26 09:28:17,2019-03-26 09:37:26,2019-03-26 09:28:17,2019-03-26 09:37:26,2019-03-26 09:37:26,4458762633d912919d7ff692cab13b69,1c85c5b774e9eabf29b9b439b8ee4584,subscription,d2033e289f1823674fd6cb332db6bf5f,expired,2019-03-26 09:28:17,2019-04-26 09:28:17,,2019-04-26 09:28:17,,,,,,true,,,USD,99.0,1,0.0,99.0,manual,canceled
2022-07-28 14:59:08,b4110f7673aa3e121abf4ffaad157f62,2019-03-26 09:25:03,2019-03-26 09:27:19,2019-03-26 09:25:03,2019-03-26 09:27:19,2019-03-26 09:27:19,4458762633d912919d7ff692cab13b69,1c85c5b774e9eabf29b9b439b8ee4584,subscription,1f5496fb1572e464194d1f6d41a91707,expired,2019-03-26 09:25:03,2019-04-26 09:25:03,,2019-04-26 09:25:03,,,,,,true,,,USD,99.0,1,0.0,99.0,automatic,canceled
2022-08-11 08:21:03,2900cfb1daef789cc21ea100ff6af6e9,2015-02-11 08:20:39,2022-08-11 08:20:39,2015-02-11 08:20:38,,,51bccf87e2571558b3da93688e17469f,1c85c5b774e9eabf29b9b439b8ee4584,subscription,81fe13285947f866c70b8102aa8f231d,active,2022-08-11 08:20:38,2022-09-11 08:20:38,2022-08-11 08:20:38,2022-09-11 08:20:38,,,0,1,1,true,,,USD,99.0,1,0.0,99.0,automatic,
2022-07-28 14:59:08,2900cfb1daef789cc21ea100ff6af6e9,2015-02-11 08:20:39,2022-07-11 08:23:42,2015-02-11 08:20:38,,,51bccf87e2571558b3da93688e17469f,1c85c5b774e9eabf29b9b439b8ee4584,subscription,81fe13285947f866c70b8102aa8f231d,active,2022-07-11 08:20:38,2022-08-11 08:20:38,2022-07-11 08:20:38,2022-08-11 08:20:38,,,0,1,1,true,,,USD,99.0,1,0.0,99.0,automatic,
2022-08-11 08:21:03,bcd3f1f36bd98895b5336e067049364b,2015-02-13 09:31:52,2022-07-20 09:32:53,2015-02-13 09:31:52,,,4458762633d912919d7ff692cab13b69,455b18e9a39e782da54de395edb6b566,subscription,971038e8a1a99aed7d9972903e0b5219,active,2022-07-20 09:31:52,2022-08-20 09:31:52,2022-07-20 09:31:52,2022-08-20 09:31:52,2015-02-13 09:31:52,2015-02-20 09:31:52,0,1,1,true,,,USD,2999.0,1,2597.0,5596.0,automatic,
7 changes: 5 additions & 2 deletions packages.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
packages:
- package: fivetran/recurly_source
version: [">=0.2.0", "<0.3.0"]
# - package: fivetran/recurly_source
# version: [">=0.3.0", "<0.4.0"]
- git: https://github.com/fivetran/dbt_recurly_source.git
revision: feature/remove-deprecated-fields
warn-unpinned: false
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder to swap before release.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto!

fivetran-catfritz marked this conversation as resolved.
Show resolved Hide resolved