feature/remove-deprecated-fields #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fivetran-joemarkiewicz
approved these changes
Nov 6, 2024
CHANGELOG.md
Outdated
| # dbt_recurly v0.5.0 | ||
| [PR #29](https://github.com/fivetran/dbt_recurly/pull/29) includes the following breaking changes: | ||
| ## Breaking Changes | ||
| - Removed unused fields from `stg_recurly__subscription_history` in the upstream `dbt_recurly_source` package (see [CHANGELOG](https://github.com/fivetran/dbt_recurly_source/blob/main/CHANGELOG.md#dbt_recurly_source-v030)): |
There was a problem hiding this comment.
Small suggestion to link the release notes instead of the CHANGELOG. This way it directs the customer to a focused version of the CHANGELOG in the form of the release.
packages.yml
Outdated
Comment on lines
2
to
6
| # - package: fivetran/recurly_source | ||
| # version: [">=0.3.0", "<0.4.0"] | ||
| - git: https://github.com/fivetran/dbt_recurly_source.git | ||
| revision: feature/remove-deprecated-fields | ||
| warn-unpinned: false |
There was a problem hiding this comment.
Reminder to swap before release.
There was a problem hiding this comment.
@fivetran-catfritz
Can you also bump the versions of the dbt_project.yml and integration_tests/dbt_project.yml?
One additional suggestion, and after that you should be good!
Co-authored-by: Avinash Kunnath <[email protected]>
There was a problem hiding this comment.
@fivetran-avinash Thanks for catching the version! I also commited your suggestion.
fivetran-avinash
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Overview
This PR will address the following Issue/Feature:
converted_atandhas_started_with_giftfields from subscription history table dbt_recurly_source#15This PR will result in the following new package version:
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
dbt run (if incremental models are present) && dbt testBefore marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please share any and all of your validation steps:
If you had to summarize this PR in an emoji, which would it be?
💃