Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(resource): set ServiceVersion to an integer #486

Merged
merged 1 commit into from
Nov 16, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion fastly/resource.go
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ type Resource struct {
// ServiceID is an alphanumeric string identifying the service.
ServiceID string `mapstructure:"service_id" json:"service_id"`
// ServiceVersion is an integer identifying a service version.
ServiceVersion string `mapstructure:"version" json:"version"`
ServiceVersion int `mapstructure:"version" json:"version"`
// UpdatedAt is the date and time in ISO 8601 format.
UpdatedAt *time.Time `mapstructure:"updated_at" json:"updated_at"`
}
Expand Down
2 changes: 1 addition & 1 deletion fastly/resource_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ func TestResourceJSONRoundtrip(t *testing.T) {
ResourceID: "the-resource-id",
ResourceType: "the-resource-type",
ServiceID: "the-service-id",
ServiceVersion: "the-service-version",
ServiceVersion: 1,
UpdatedAt: &now,
}

Expand Down
Loading