Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(resource): set ServiceVersion to an integer #486

Merged
merged 1 commit into from
Nov 16, 2023
Merged

fix(resource): set ServiceVersion to an integer #486

merged 1 commit into from
Nov 16, 2023

Conversation

fgsch
Copy link
Member

@fgsch fgsch commented Nov 15, 2023

Matches the type the resource API returns.

@fgsch
Use integer instead of string
d2e41be 
Matches the type the resource API returns.
@fgsch
Copy link
Member Author

fgsch commented Nov 15, 2023

I've confirmed this across all the endpoints documented at https://developer.fastly.com/reference/api/services/resource/.

@fgsch fgsch requested a review from Integralist November 15, 2023 15:53
@Integralist Integralist changed the title Use integer instead of string fix(resource): set ServiceVersion to an integer Nov 15, 2023
Integralist
Integralist approved these changes Nov 15, 2023
View reviewed changes
Copy link
Collaborator

@Integralist Integralist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

But would you be able to regenerate the fixtures just to be sure this works as expected.

Thanks!

@Integralist Integralist merged commit 80bacef into main Nov 16, 2023
2 checks passed
@Integralist Integralist deleted the fgsch/update-service-version-type branch November 16, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Integralist Integralist Integralist approved these changes

Assignees
No one assigned
Labels
breaking-change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fgsch @Integralist