generated from pitmonticone/LeanProject
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fill in some admitted proofs #64
Merged
Merged
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
27432e7
Prove IsConicalTerminal.sHomIso
gio256 c16d628
Prove IsConicalTerminal.ofIso
gio256 57f70ae
Prove conicalTerminalIsConicalTerminal
gio256 699160f
Add sHomWhiskerLeftIso and friends
gio256 f750c55
Clean up conicalTerminalIsConicalTerminal
gio256 42efdb7
Replace eHomWhiskerLeftIso with eHomCongr
gio256 182a3d9
Add IsSLimit.ofIsoSLimit
gio256 700a71a
Remove eHomCongr and sHomCongr
gio256 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30 changes: 30 additions & 0 deletions
30
InfinityCosmos/ForMathlib/CategoryTheory/Enriched/Ordinary.lean
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
import Mathlib.CategoryTheory.Enriched.Ordinary | ||
|
||
universe v' v u u' | ||
|
||
open CategoryTheory Category MonoidalCategory | ||
|
||
namespace CategoryTheory | ||
|
||
variable (V : Type u') [Category.{v'} V] [MonoidalCategory V] | ||
{C : Type u} [Category.{v} C] [EnrichedOrdinaryCategory V C] | ||
|
||
def eHomWhiskerLeftIso (X : C) {Y Y' : C} (i : Y ≅ Y') : | ||
(X ⟶[V] Y) ≅ (X ⟶[V] Y') where | ||
hom := eHomWhiskerLeft V X i.hom | ||
inv := eHomWhiskerLeft V X i.inv | ||
hom_inv_id := by | ||
rw [← eHomWhiskerLeft_comp, i.hom_inv_id, eHomWhiskerLeft_id] | ||
inv_hom_id := by | ||
rw [← eHomWhiskerLeft_comp, i.inv_hom_id, eHomWhiskerLeft_id] | ||
|
||
def eHomWhiskerRightIso {X X' : C} (i : X ≅ X') (Y : C) : | ||
(X' ⟶[V] Y) ≅ (X ⟶[V] Y) where | ||
hom := eHomWhiskerRight V i.hom Y | ||
inv := eHomWhiskerRight V i.inv Y | ||
hom_inv_id := by | ||
rw [← eHomWhiskerRight_comp, i.inv_hom_id, eHomWhiskerRight_id] | ||
inv_hom_id := by | ||
rw [← eHomWhiskerRight_comp, i.hom_inv_id, eHomWhiskerRight_id] | ||
|
||
end CategoryTheory |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The (two-sided) unenriched analogue appears to be
CategoryTheory.Iso.homCongr
. Perhaps this deserves a more complete treatment than I've given here (or at least a better name)?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added
eHomCongr
andsHomCongr
to be more consistent with the unenriched version of the api here, but I stopped short of adding analogues for all of the additional lemmas inMathlib/CategoryTheory/HomCongr.lean
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update: I implemented a more direct proof of
IsSLimit.ofIsoSLimit
that removed the need foreHomCongr
. I think it's probably still a good thing to eventually have in mathlib, but it doesn't necessarily need to be in this PR.